theme with video previews ?

[jackalpret]

@acris said in theme with video previews ?:

Hello
recalbox had own version of emulationstation.

thanks, yeah i known, but maybe it could be included, is only a few lines of code (and binaries of vlc and libs)

[acris]

@rockaddicted works on it and it's more complicate than it seems.

RECALBOX IS NOT RASPBIAN but buildroot OS.

seem question : https://forum.recalbox.com/topic/4761/emulationstation-video-preview/3

[jackalpret]

@acris said in theme with video previews ?:

@rockaddicted works on it and it's more complicate than it seems.

RECALBOX IS NOT RASPBIAN but buildroot OS.

Thanks, it seems on this commit only add a few lines and install vlc and dependencies
But, always born a problem haha

@rockaddicted is already working on it ? WOW !!!! AMAZINGGGGGGGGG ! F*CK YEAH !

[rockaddicted]

Yep indeed I have a WIP about that using ffmepg instead of vlc.
But no time to work on it for the moment. I'll give a look later once the 4.1 stable version released.

[Substring]

@jackalpret as you definitely have absolutely no understanding of what a few lines of code + merging this into the recalbox version of ES + adding VLC to recalbox

Do you know how often we've seen people just copying/pasting this code into our source code, making a pull request and when we ask them how they tested it they just answer "i have no idea of what i have done, i just copied/pasted and pushed it, i don't understand a single line of what I've added, and i don't even know how to compile", we can't accept such a contribution.

fieldsofcows made some very amazing job to retropie's ES, it can't be backported to recalbox by just c/c. And anyway, we'd rather not include VLC.

So, yes, it is a problem. You need to :

• manage themes evolution
• manage fallback to pictures if no video exists
• resize the video and keep its aspect ratio
• thouroughly test
• take care of memory leaks

Please, just don't say "it's just a few lines of code" unless you're in IT and know C++ better than us Such a sentence is very irritating you know ...

[jackalpret]

@rockaddicted said in theme with video previews ?:

Yep indeed I have a WIP about that using ffmepg instead of vlc.
But no time to work on it for the moment. I'll give a look later once the 4.1 stable version released.

amazing ! thanks !!!

[jackalpret]

@Substring said in theme with video previews ?:

@jackalpret as you definitely have absolutely no understanding of what a few lines of code + merging this into the recalbox version of ES + adding VLC to recalbox

Do you know how often we've seen people just copying/pasting this code into our source code, making a pull request and when we ask them how they tested it they just answer "i have no idea of what i have done, i just copied/pasted and pushed it, i don't understand a single line of what I've added, and i don't even know how to compile", we can't accept such a contribution.

fieldsofcows made some very amazing job to retropie's ES, it can't be backported to recalbox by just c/c. And anyway, we'd rather not include VLC.

So, yes, it is a problem. You need to :

• manage themes evolution
• manage fallback to pictures if no video exists
• resize the video and keep its aspect ratio
• thouroughly test
• take care of memory leaks

Please, just don't say "it's just a few lines of code" unless you're in IT and know C++ better than us Such a sentence is very irritating you know ...

If you look again I write "as I saw on this commit" ... talking about mod for this version ...

I'm developer, I work with git, docker, docker-compose, jenkins, vagrant, jmeter, phpunit, protractor, php, angularjs, jquery, etc etc
I know sometime about development

obviously I'm joking about "few lines of code" ... thats what my product managers said all the time hahaha

[Substring]

@jackalpret dev humor hahaha ok I'm sure you love when your manager says "just a few lines of code"

still, VLC is not the way we want to go. And just thought about a major concern : x86 versions use X11, not framebuffer ... d**n ...

[jackalpret]

@Substring said in theme with video previews ?:

@jackalpret dev humor hahaha ok I'm sure you love when your manager says "just a few lines of code"

still, VLC is not the way we want to go. And just thought about a major concern : x86 versions use X11, not framebuffer ... d**n ...

haha yeah, or "it takes only 2 minutes..." ... XD

perfect, i think ffmpeg takes lower memory than vlc , because if you stay a few minutes in the same screen with the video runnning, maybe the raspi begins to burn if you dont take care about memory and processor resources ...

[Substring]

@jackalpret I have a much better trick up my sleeve in favor of ffmpeg : it handles hardware decoding of H264 on the pi

[jackalpret]

@Substring yeah !
I use ffmpeg in console to convert videos into different formats to copy to different devices to my doughter