Recalbox Forum

    • Register
    • Login
    • Search
    • Recent
    • Tags
    • recalbox.com
    • Gitlab repository
    • Documentation
    • Discord

    theme with video previews ?

    Themes & Interface
    theme previews
    5
    15
    10614
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • acris
      acris last edited by acris

      Hello
      recalbox had own version of emulationstation.
      this option is in WIP for recalbox

      jackalpret 1 Reply Last reply Reply Quote 0
      • jackalpret
        jackalpret Translator @acris last edited by

        @acris said in theme with video previews ?:

        Hello
        recalbox had own version of emulationstation.

        thanks, yeah i known, but maybe it could be included, is only a few lines of code (and binaries of vlc and libs)

        1 Reply Last reply Reply Quote 0
        • acris
          acris last edited by acris

          @rockaddicted works on it and it's more complicate than it seems.

          RECALBOX IS NOT RASPBIAN 😉 but buildroot OS. 😛

          seem question : https://forum.recalbox.com/topic/4761/emulationstation-video-preview/3

          jackalpret 1 Reply Last reply Reply Quote 0
          • jackalpret
            jackalpret Translator @acris last edited by

            @acris said in theme with video previews ?:

            @rockaddicted works on it and it's more complicate than it seems.

            RECALBOX IS NOT RASPBIAN 😉 but buildroot OS. 😛

            Thanks, it seems on this commit only add a few lines and install vlc and dependencies
            But, always born a problem haha

            @rockaddicted is already working on it ? WOW !!!! AMAZINGGGGGGGGG ! F*CK YEAH !

            rockaddicted Substring 2 Replies Last reply Reply Quote 0
            • rockaddicted
              rockaddicted @jackalpret last edited by

              Yep indeed I have a WIP about that using ffmepg instead of vlc.
              But no time to work on it for the moment. I'll give a look later once the 4.1 stable version released.

              Recalbox V4.1.0 - RPI3 OC - Xbox360 wireless
              Wiki ENG : https://github.com/recalbox/recalbox-os/wiki/Mini-How-To-(EN)
              Wiki FR : https://github.com/recalbox/recalbox-os/wiki/Mini-How-To-(FR)

              Don't forget to upvote messages if it has been useful ;)

              jackalpret 1 Reply Last reply Reply Quote 0
              • Substring
                Substring @jackalpret last edited by

                @jackalpret as you definitely have absolutely no understanding of what a few lines of code + merging this into the recalbox version of ES + adding VLC to recalbox

                Do you know how often we've seen people just copying/pasting this code into our source code, making a pull request and when we ask them how they tested it they just answer "i have no idea of what i have done, i just copied/pasted and pushed it, i don't understand a single line of what I've added, and i don't even know how to compile", we can't accept such a contribution.

                fieldsofcows made some very amazing job to retropie's ES, it can't be backported to recalbox by just c/c. And anyway, we'd rather not include VLC.

                So, yes, it is a problem. You need to :

                • manage themes evolution
                • manage fallback to pictures if no video exists
                • resize the video and keep its aspect ratio
                • thouroughly test
                • take care of memory leaks

                Please, just don't say "it's just a few lines of code" unless you're in IT and know C++ better than us 🙂 Such a sentence is very irritating you know ...

                Former dev - Please reply with @substring so that i am notified when you answer me
                Ex dev - Merci de me répondre en utilisant @substring pour que je sois notifé

                jackalpret 1 Reply Last reply Reply Quote 4
                • jackalpret
                  jackalpret Translator @rockaddicted last edited by

                  @rockaddicted said in theme with video previews ?:

                  Yep indeed I have a WIP about that using ffmepg instead of vlc.
                  But no time to work on it for the moment. I'll give a look later once the 4.1 stable version released.

                  amazing ! thanks !!!

                  1 Reply Last reply Reply Quote 0
                  • jackalpret
                    jackalpret Translator @Substring last edited by

                    @Substring said in theme with video previews ?:

                    @jackalpret as you definitely have absolutely no understanding of what a few lines of code + merging this into the recalbox version of ES + adding VLC to recalbox

                    Do you know how often we've seen people just copying/pasting this code into our source code, making a pull request and when we ask them how they tested it they just answer "i have no idea of what i have done, i just copied/pasted and pushed it, i don't understand a single line of what I've added, and i don't even know how to compile", we can't accept such a contribution.

                    fieldsofcows made some very amazing job to retropie's ES, it can't be backported to recalbox by just c/c. And anyway, we'd rather not include VLC.

                    So, yes, it is a problem. You need to :

                    • manage themes evolution
                    • manage fallback to pictures if no video exists
                    • resize the video and keep its aspect ratio
                    • thouroughly test
                    • take care of memory leaks

                    Please, just don't say "it's just a few lines of code" unless you're in IT and know C++ better than us 🙂 Such a sentence is very irritating you know ...

                    If you look again I write "as I saw on this commit" ... talking about mod for this version ...

                    I'm developer, I work with git, docker, docker-compose, jenkins, vagrant, jmeter, phpunit, protractor, php, angularjs, jquery, etc etc
                    I know sometime about development 😉

                    obviously I'm joking about "few lines of code" ... thats what my product managers said all the time hahaha

                    Substring 1 Reply Last reply Reply Quote 0
                    • Substring
                      Substring @jackalpret last edited by

                      @jackalpret dev humor hahaha ok 😉 I'm sure you love when your manager says "just a few lines of code" 😉

                      still, VLC is not the way we want to go. And just thought about a major concern : x86 versions use X11, not framebuffer ... d**n ...

                      Former dev - Please reply with @substring so that i am notified when you answer me
                      Ex dev - Merci de me répondre en utilisant @substring pour que je sois notifé

                      jackalpret 1 Reply Last reply Reply Quote 1
                      • jackalpret
                        jackalpret Translator @Substring last edited by

                        @Substring said in theme with video previews ?:

                        @jackalpret dev humor hahaha ok 😉 I'm sure you love when your manager says "just a few lines of code" 😉

                        still, VLC is not the way we want to go. And just thought about a major concern : x86 versions use X11, not framebuffer ... d**n ...

                        haha yeah, or "it takes only 2 minutes..." ... XD

                        perfect, i think ffmpeg takes lower memory than vlc , because if you stay a few minutes in the same screen with the video runnning, maybe the raspi begins to burn if you dont take care about memory and processor resources ...

                        Substring 1 Reply Last reply Reply Quote 0
                        • Substring
                          Substring @jackalpret last edited by

                          @jackalpret I have a much better trick up my sleeve in favor of ffmpeg : it handles hardware decoding of H264 on the pi 😉

                          Former dev - Please reply with @substring so that i am notified when you answer me
                          Ex dev - Merci de me répondre en utilisant @substring pour que je sois notifé

                          jackalpret 1 Reply Last reply Reply Quote 0
                          • jackalpret
                            jackalpret Translator @Substring last edited by

                            @Substring yeah !
                            I use ffmpeg in console to convert videos into different formats to copy to different devices to my doughter 🙂

                            1 Reply Last reply Reply Quote 0
                            • First post
                              Last post

                            Want to support us ?

                            74
                            Online

                            99.6k
                            Users

                            28.1k
                            Topics

                            187.1k
                            Posts

                            Copyright © 2021 recalbox.com