cant add favorites with controller

[jackalpret]

@paradadf said in cant add favorites with controller:

@jackalpret as @azvarel said, it needs to be supported by the theme. Just try using the official one and see the difference.

yeah , both of you have the reason
can i add this "option" to my theme ?

[paradadf]

@jackalpret azvarel just told you the two fields thst need to be added to the xml files of the theme. In your case I would just compare yours wirh the official and see what other fields are missing.

[jackalpret]

@paradadf In the new theme I dont have anything with "favorite" ...

lines with md_ in my theme:

<text name="md_lbl_publisher, md_lbl_lastplayed, md_lbl_playcount, md_publisher, md_playcount, md_description,md_lbl_rating">
		<fontPath>./main/fonts/Dosis-SemiBold.ttf</fontPath>
		<fontSize>0.01</fontSize>
		<pos>-50 -50</pos>
	</text>
		
	<datetime name="md_lastplayed">
		<fontPath>./main/fonts/Dosis-SemiBold.ttf</fontPath>
		<fontSize>0.01</fontSize>
		<pos>-50 -50</pos>
	</datetime>
	
	<text name="md_lbl_releasedate, md_lbl_developer, md_lbl_genre, md_lbl_players">
		<forceUppercase>1</forceUppercase>
		<fontPath>./main/fonts/Dosis-Bold.ttf</fontPath>
		<fontSize>0.025</fontSize>
		<size>0.111 0.015</size>
		<alignment>right</alignment>
	</text>
	
	<text name="md_developer">
		<forceUppercase>1</forceUppercase>
		<fontPath>./main/fonts/Dosis-SemiBold.ttf</fontPath>
		<fontSize>0.025</fontSize>
		<size>0.187 0.015</size>
	</text>
	
	<text name="md_genre, md_players">
		<forceUppercase>1</forceUppercase>
		<fontPath>./main/fonts/Dosis-SemiBold.ttf</fontPath>
		<fontSize>0.025</fontSize>
		<size>0.187 0.015</size>
	</text>
	
	<datetime name="md_releasedate">
		<forceUppercase>1</forceUppercase>	
		<fontPath>./main/fonts/Dosis-SemiBold.ttf</fontPath>
		<fontSize>0.025</fontSize>
		<size>0.2 0.015</size>
	</datetime>

in the oficial theme i have:

<text name="md_lbl_rating, md_lbl_releasedate, md_lbl_developer, md_lbl_publisher, md_lbl_genre, md_lbl_players, md_lbl_lastplayed, md_lbl_playcount, md_lbl_favorite">
			<color>262626</color>
			<forceUppercase>1</forceUppercase>
			<fontPath>./data/ubuntu_condensed.ttf</fontPath>
			<fontSize>0.03</fontSize>
			<size>0.12 0.04</size>
		</text>
		<text name="md_developer, md_publisher, md_genre, md_players, md_playcount, md_favorite, md_rating">
			<color>262626</color>
			<forceUppercase>1</forceUppercase>
			<fontPath>./data/ubuntu_condensed.ttf</fontPath>
			<fontSize>0.03</fontSize>
			<size>0.12 0.04</size>
		</text>
		<text name="md_description">
			<color>262626</color>
			<forceUppercase>1</forceUppercase>
			<fontPath>./data/ubuntu_condensed.ttf</fontPath>
			<fontSize>0.03</fontSize>
		</text>
		<datetime name="md_releasedate, md_lastplayed">
			<color>262626</color>
			<forceUppercase>1</forceUppercase>
			<fontPath>./data/ubuntu_condensed.ttf</fontPath>
			<fontSize>0.03</fontSize>
			<size>0 0.04</size>
		</datetime>

I need to add all these lines ? with md_plashers, publisher, etc ? or only md_favorite and md_lbl_favorite ?

[paradadf]

@jackalpret you don't must add all fields, but you can.
For the favorites tag you only need:
md_lbl_favorite and md_favorites
Nothing else

[jackalpret]

perfect thanks !
i will try later and re-upload the theme when it works

[voljega]

@jackalpret also your themes files must be in version 4

[azvarel]

@voljega That's right, I forgot to say

[jackalpret]

I added these lines and doesnt work:

	<text name="md_lbl_favorite">
		<color>262626</color>
		<forceUppercase>1</forceUppercase>
		<fontPath>./data/ubuntu_condensed.ttf</fontPath>
		<fontSize>0.03</fontSize>
		<size>0.12 0.04</size>
	</text>
	<text name="md_favorite">
		<color>262626</color>
		<forceUppercase>1</forceUppercase>
		<fontPath>./data/ubuntu_condensed.ttf</fontPath>
		<fontSize>0.03</fontSize>
		<size>0.12 0.04</size>
	</text>

and version 4 in the first lines

[paradadf]

@jackalpret the first line wirh lbl needs to be on top of everything (for what I can tell). Look sharply and compare. The first line contains many md_lbl_xx, one after another.
But I never edited that so I have actually no idea!

[jackalpret]

@paradadf
could you correct my lines and reply with the correct order or changes ?

thats the content of my xml file:

http://pastebin.com/zDF9VWK7

[paradadf]

@jackalpret I meant something like this:
http://pastebin.com/dqerkbaA
But there are big chances I'm completely wrong XD

[jackalpret]

@paradadf said in cant add favorites with controller:

@jackalpret I meant something like this:
http://pastebin.com/dqerkbaA
But there are big chances I'm completely wrong XD

I brokes the theme

[paradadf]

@jackalpret hahahaha sorry!

[jackalpret]

@paradadf no problem !

anyone else that can help ?

[rockaddicted]

problem solved ?

[jackalpret]

@rockaddicted said in cant add favorites with controller:

problem solved ?

noup, doesnt work, I cant add the option in xml theme to add favorites with controller

[rockaddicted]

Can you post the theme, I'll give a look.

[jackalpret]

@rockaddicted said in cant add favorites with controller:

Can you post the theme, I'll give a look.

https://forum.recalbox.com/topic/6754/new-theme

[rockaddicted]

@jackalpret ok so you have to edit the main theme.xml, on the root, like this :

	<datetime name="md_releasedate">
		<forceUppercase>1</forceUppercase>	
		<fontPath>./main/fonts/Dosis-SemiBold.ttf</fontPath>
		<fontSize>0.025</fontSize>
		<size>0.2 0.015</size>
	</datetime>
	
	<text name="md_lbl_favorite, md_favorite">
		<fontPath>./main/fonts/AdobeBlank.ttf</fontPath>
	</text>
	
</view>

Add the favorites metadata md_lbl_favorite, md_favoriteat the end of this file.
You'll have to add too this blank font in ./main/fonts/

Now, for each system, you'll have to edit the ./system_name/theme.xml like this :

<theme>
<formatVersion>4</formatVersion>
<include>./../theme.xml</include>

<view name="system">

Once all these modifications done, your theme should support favorites.

[jackalpret]

@rockaddicted amazing ! thanks !
i will try when return to my home at night and then i will comment here