SMB v2 support

[Substring]

@shira Hi

You can add it by yourself if you wish, someone is testing that for now. But right now, I don't want to risk any regression bug with the SMB protocol version, so I think we'll keep it to v1 still for now.

[Substring]

The tests are in French, but it's easy to see what to do : https://forum.recalbox.com/post/81489

[Shira]

@oyyodams to keep SMB v1 disabled in my computers

http://www.zdnet.com/article/windows-10-tip-stop-using-the-horribly-insecure-smbv1-protocol/
https://www.howtogeek.com/321072/how-to-disable-smbv1-and-protect-your-windows-pc-from-attack/
https://www.spamtitan.com/blog/stop-smbv1-ransomware-attacks/
https://www.bostonhelpdesk.com/disabling-smbv1-one-defense-against-wanna-cry-ransomware/

[Shira]

https://forum.kodi.tv/showthread.php?tid=316881

"Windows 10 dropping support for SMB v1"

[Shira]

@substring it doesn't work. I did:

- edited /etc/samba/smb.conf and smb-secure.conf:
[global]
min protocol = SMB2
max protocol = SMB3

- edited /boot/recalbox-boot.conf:
internal=/dev/mmcblk0p8
sharedevice=NETWORK
sharenetwork_smb1=ROMS@192.168.0.2:RecalboxRoms:username=roms,password=roms
sharenetwork_smb2=SAVES@192.168.0.2:RecalboxSaves:username=roms,password=roms

- restarted. no roms

- Tested the login from my phone, the share is properly setup:

- Tested connectivity to the recalbox:

Pinging recalbox [192.168.0.101] with 32 bytes of data:
Reply from 192.168.0.101: bytes=32 time<1ms TTL=64
Reply from 192.168.0.101: bytes=32 time<1ms TTL=64
Reply from 192.168.0.101: bytes=32 time<1ms TTL=64
Reply from 192.168.0.101: bytes=32 time<1ms TTL=64

- Tested connectivity from within the Pi:

# ping 192.168.0.2
PING 192.168.0.2 (192.168.0.2): 56 data bytes
64 bytes from 192.168.0.2: seq=0 ttl=128 time=0.514 ms
64 bytes from 192.168.0.2: seq=1 ttl=128 time=0.365 ms
64 bytes from 192.168.0.2: seq=2 ttl=128 time=0.363 ms

[Substring]

@shira I edited the file, and :

# testparm 
Load smb config files from /etc/samba/smb.conf
rlimit_max: increasing rlimit_max (1024) to minimum Windows limit (16384)
WARNING: The "syslog" option is deprecated
Processing section "[homes]"
Processing section "[share]"
Loaded services file OK.
Server role: ROLE_STANDALONE

Press enter to see a dump of your service definitions

# Global parameters
[global]
	server string = %h server
	log file = /var/log/samba/log.%m
	max log size = 1000
	syslog = 0
	panic action = /usr/share/samba/panic-action %d
	usershare allow guests = Yes
	disable spoolss = Yes
	load printers = No
	printcap name = /dev/null
	protocol = SMB2
	map to guest = Bad User
	obey pam restrictions = Yes
	pam password change = Yes
	passwd chat = *Enter\snew\s*\spassword:* %n\n *Retype\snew\s*\spassword:* %n\n *password\supdated\ssuccessfully* .
	passwd program = /usr/bin/passwd %u
	unix password sync = Yes
	dns proxy = No
	idmap config * : backend = tdb


[homes]
	comment = Home Directories
	browseable = No
	create mask = 0700
	directory mask = 0700
	valid users = %S


[share]
	comment = Recalbox user data
	path = /recalbox/share
	delete veto files = Yes
	veto files = /._*/.DS_Store/
	create mask = 0644
	force user = root
	guest ok = Yes
	read only = No

worked for me from my Ubuntu (notice protocol = SMB2).

Anyway, this has to do with the Recalbox server samba server, nothing to do at all with connecting to your NAS

[Shira]

@substring what I need is to load the roms from my PC shares, so in this case the problem is with the recalbox smb client

[Substring]

@shira then please read the wiki, this has absolutely nothing to do with the protocol version

[Shira]

@substring it does, if my pc or nas has v1 removed then we need recalbox to be able to access smb v2 shares

[Shira]

# mount.cifs //192.168.0.2/RecalboxRoms /recalbox/share/roms -o username=roms,password=roms
mount error(112): Host is down
Refer to the mount.cifs(8) manual page (e.g. man mount.cifs)

[Shira]

@substring got it working, we simply have to add "vers=2.0" (or 2.1 / 3.0 /3.02) to the mount commands, i.e:

sharenetwork_smb1=ROMS@192.168.0.2:RecalboxRoms:username=roms,password=roms,vers=2.0
sharenetwork_smb2=SAVES@192.168.0.2:RecalboxSaves:username=roms,password=roms,vers=2.0

https://blogs.technet.microsoft.com/josebda/2013/10/02/windows-server-2012-r2-which-version-of-the-smb-protocol-smb-1-0-smb-2-0-smb-2-1-smb-3-0-or-smb-3-02-are-you-using/

1.0: Win 2k/XP/Server 2003/Server 2003 R2
2.0: Vista SP1/Server 2008
2.1: Win7/Server 2008 R2
3.0: Win8/Server 2012 (w10?)
3.02: Win8.1/Server2012 (w10?)

[Shira]

Edited the Wiki with these instructions:

https://github.com/recalbox/recalbox-os/wiki/Load-your-roms-from-a-network-shared-folder-(EN)

[Shira]

for KODI SMB2+: SMB v2 on KODI

[Substring]

@shira great job !
Still, it's a shame it can't properly "autodetect" the protocol version

[toniosj]

@shira Do you use Windows10? Does dosbox work with shared folder from Windows 10?

[Shira]

@toniosj Yes Win10. Dosbox?

[toniosj]

@shira Since 17.12.2, dosbox doesnt detect my roms folder shared from Windows. All rest emulators work perfectly. And you?

[Shira]

@toniosj hm I don't have any dosbox games to test

[toniosj]

@shira I've send you a chat.