Recalbox Forum

    • Register
    • Login
    • Search
    • Recent
    • Tags
    • recalbox.com
    • Gitlab repository
    • Documentation
    • Discord

    18.03.16 - Moonlight

    Emulator Arcade/PC/Console
    18.03.16 moonlight
    3
    32
    8951
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • Substring
      Substring @nwildner last edited by

      @nwildner i'd rather review their code first

      Former dev - Please reply with @substring so that i am notified when you answer me
      Ex dev - Merci de me répondre en utilisant @substring pour que je sois notifé

      1 Reply Last reply Reply Quote 0
      • Substring
        Substring @nwildner last edited by

        @nwildner So i've dived in the code ... moonlight computes itself the GUID instead of calling SDL2 dedicated methods 😕

        Former dev - Please reply with @substring so that i am notified when you answer me
        Ex dev - Merci de me répondre en utilisant @substring pour que je sois notifé

        nwildner 1 Reply Last reply Reply Quote 0
        • nwildner
          nwildner @Substring last edited by

          @substring Yeah. I'm browsing through Recalbox-EmulationStation source and it's pretty clean C++ SDL call, while moonlight gets it by computing with the following code:

          evdev.c(tag 2.4.6)

          struct libevdev *evdev = libevdev_new();
          libevdev_set_fd(evdev, fd);
          const char* name = libevdev_get_name(evdev);
          
          int16_t guid[8] = {0};
          guid[0] = int16_to_le(libevdev_get_id_bustype(evdev));
          guid[2] = int16_to_le(libevdev_get_id_vendor(evdev));
          guid[4] = int16_to_le(libevdev_get_id_product(evdev));
          guid[6] = int16_to_le(libevdev_get_id_version(evdev));
          
          char str_guid[33];
          char* buf = str_guid;
          for (int i = 0; i < 16; i++)
              buf += sprintf(buf, "%02x", ((unsigned char*) guid)[i]);
          

          Maybe i should open an issue on moonlight-embedded Github after all? (and link this thread)...

          PT_BR Retrogaming on Telegram

          Substring 1 Reply Last reply Reply Quote 0
          • Substring
            Substring @nwildner last edited by

            @nwildner Why not ... But I think he computed it himself simply because he may not have found how to link an input and its guid. Anyway, I know SDL changed their way of computing the GUID over time, SDL 2.0.8 uses the mthod he chose, i don't know since when. This also means that when we b*mp to SDL 2.0.7 we should hopefully fit. Stupid me, i do have a SDL 2.0.7 pi3 build, i will try to find some time to test with my shanwan.

            Final word : he should rely on SDL2 to get the GUID, period.

            Former dev - Please reply with @substring so that i am notified when you answer me
            Ex dev - Merci de me répondre en utilisant @substring pour que je sois notifé

            nwildner 2 Replies Last reply Reply Quote 0
            • nwildner
              nwildner @Substring last edited by

              @substring It's done.

              Let's see if this could make Moonlight better integrated with Recalbox 🙂

              https://github.com/irtimmer/moonlight-embedded/issues/644

              PT_BR Retrogaming on Telegram

              1 Reply Last reply Reply Quote 0
              • nwildner
                nwildner @Substring last edited by

                @substring Hey Subs! Is it possible to cherry-pick commit dcda1a5, and try the irtimmer fix on your SDL build?

                It seems that devices with no vendor or product id are handled different, by copying the first 11 Characters(PLAYSTATION) to GUID.

                PT_BR Retrogaming on Telegram

                Substring 1 Reply Last reply Reply Quote 0
                • Substring
                  Substring @nwildner last edited by

                  @nwildner yep easy
                  Just need to add a .patch to the commit url, add it to the package and it should be good to go. Can you open an issue and assign it to me please ?

                  Former dev - Please reply with @substring so that i am notified when you answer me
                  Ex dev - Merci de me répondre en utilisant @substring pour que je sois notifé

                  1 Reply Last reply Reply Quote 0
                  • Substring
                    Substring last edited by

                    Will do it, nevermind 😉

                    Former dev - Please reply with @substring so that i am notified when you answer me
                    Ex dev - Merci de me répondre en utilisant @substring pour que je sois notifé

                    nwildner Gimpi 2 Replies Last reply Reply Quote 0
                    • nwildner
                      nwildner @Substring last edited by

                      @substring Thanks.

                      I was going to do right now(Gitlab is not allowed at my workplace)

                      PT_BR Retrogaming on Telegram

                      1 Reply Last reply Reply Quote 0
                      • Gimpi
                        Gimpi @Substring last edited by

                        @substring Sorry for my dumb ess 18.03.30 is Out and installed moonlight still dont realised my Bluetooth controller

                        Substring 1 Reply Last reply Reply Quote 0
                        • Substring
                          Substring @Gimpi last edited by

                          @gimpi i don't understand

                          Former dev - Please reply with @substring so that i am notified when you answer me
                          Ex dev - Merci de me répondre en utilisant @substring pour que je sois notifé

                          Gimpi 1 Reply Last reply Reply Quote 0
                          • Gimpi
                            Gimpi @Substring last edited by

                            @substring the Update said some fixes in the moonlight Installation but my Bluetooth controller will Not Work while streaming any USB plugged Controller worked

                            Substring 1 Reply Last reply Reply Quote 0
                            • Substring
                              Substring @Gimpi last edited by

                              @gimpi i haven't tried with any bluetooth controller in fact

                              Former dev - Please reply with @substring so that i am notified when you answer me
                              Ex dev - Merci de me répondre en utilisant @substring pour que je sois notifé

                              Gimpi 1 Reply Last reply Reply Quote 0
                              • Gimpi
                                Gimpi @Substring last edited by

                                @substring ok in the "christmas" recalbox Patch it worked Like a Charm with an Bluetooth Hmm ok im Just trying now

                                Substring 1 Reply Last reply Reply Quote 0
                                • Substring
                                  Substring @Gimpi last edited by

                                  @gimpi because moonlight had to be updated since to be compatible with GFE 3.12. But the pad configuration routines changed. I'll try and see if the dev how this goes. Which pad doesn"t work ? can you provide a support archive ?

                                  Former dev - Please reply with @substring so that i am notified when you answer me
                                  Ex dev - Merci de me répondre en utilisant @substring pour que je sois notifé

                                  Gimpi 1 Reply Last reply Reply Quote 0
                                  • Gimpi
                                    Gimpi @Substring last edited by

                                    @substring its an third Party ps3 bluetooth controller from "big ben"

                                    How Do i create an Support archive? Can try it after Work tonight

                                    Substring 1 Reply Last reply Reply Quote 0
                                    • Substring
                                      Substring @Gimpi last edited by

                                      @gimpi start recalbox, go to http://recalbox/help or http://recalbox.local/help if you're on MAC/Linux

                                      Former dev - Please reply with @substring so that i am notified when you answer me
                                      Ex dev - Merci de me répondre en utilisant @substring pour que je sois notifé

                                      Gimpi 2 Replies Last reply Reply Quote 0
                                      • Gimpi
                                        Gimpi @Substring last edited by

                                        @substring sorry a day later but last night im was to tired from work but here the support link https://file.ac/hTP96AeqSDQ/

                                        1 Reply Last reply Reply Quote 0
                                        • Gimpi
                                          Gimpi @Substring last edited by

                                          @substring b*mb ?

                                          any fixing tipps ?

                                          Substring 1 Reply Last reply Reply Quote 0
                                          • Substring
                                            Substring @Gimpi last edited by

                                            @gimpi could find much of a source of a problem, haven't had time to dig much further

                                            Former dev - Please reply with @substring so that i am notified when you answer me
                                            Ex dev - Merci de me répondre en utilisant @substring pour que je sois notifé

                                            1 Reply Last reply Reply Quote 0
                                            • First post
                                              Last post

                                            Want to support us ?

                                            85
                                            Online

                                            99.6k
                                            Users

                                            28.1k
                                            Topics

                                            187.1k
                                            Posts

                                            Copyright © 2021 recalbox.com